'Creating a promise chain in a for loop
I would expect the code below to print one number on the console, then wait a second and then print another number. Instead, it prints all 10 numbers immediately and then waits ten seconds. What is the correct way to create a promise chain that behaves as described?
function getProm(v) {
return new Promise(resolve => {
console.log(v);
resolve();
})
}
function Wait() {
return new Promise(r => setTimeout(r, 1000))
}
function createChain() {
let a = [1, 2, 3, 4, 5, 6, 7, 8, 9, 0];
let chain = Promise.resolve();
for (let i of a) {
chain.then(()=>getProm(i))
.then(Wait)
}
return chain;
}
createChain();
Solution 1:[1]
You have to assign the return value of .then
back to chain
:
chain = chain.then(()=>getProm(i))
.then(Wait)
Now you will basically be doing
chain
.then(()=>getProm(1))
.then(Wait)
.then(()=>getProm(2))
.then(Wait)
.then(()=>getProm(3))
.then(Wait)
// ...
instead of
chain
.then(()=>getProm(1))
.then(Wait)
chain
.then(()=>getProm(2))
.then(Wait)
chain
.then(()=>getProm(3))
.then(Wait)
// ...
You can see that the first one is actually a chain, while the second one is parallel.
Solution 2:[2]
See Resolve promises one after another (i.e. in sequence)?.
Using i of a
:
function createChain() {
let a = [1, 2, 3, 4, 5, 6, 7, 8, 9, 0];
let chain = Promise.resolve();
for (let i of a) {
chain = chain.then(()=>getProm(i))
.then(Wait)
}
return chain;
}
Using a.forEach()
function createChain() {
let a = [1, 2, 3, 4, 5, 6, 7, 8, 9, 0];
let chain = Promise.resolve();
a.forEach(i =>
chain = chain.then(()=>getProm(i))
.then(Wait)
);
return chain;
}
Using a.reduce()
function createChain() {
let a = [1, 2, 3, 4, 5, 6, 7, 8, 9, 0];
return a.reduce((chain, i) =>
chain.then(()=>getProm(i))
.then(Wait),
Promise.resolve()
);
}
Solution 3:[3]
Now that we have await
/async
, a better way to do this is:
function getProm(v) {
return new Promise(resolve => {
console.log(v);
resolve();
})
}
function Wait() {
return new Promise(r => setTimeout(r, 1000))
}
async function createChain() {
let a = [1, 2, 3, 4, 5, 6, 7, 8, 9, 0];
for (let i of a) {
await getProm(i);
await Wait();
}
}
createChain();
Sources
This article follows the attribution requirements of Stack Overflow and is licensed under CC BY-SA 3.0.
Source: Stack Overflow
Solution | Source |
---|---|
Solution 1 | Felix Kling |
Solution 2 | Smiley1000 |
Solution 3 | TLP |