Ternary operator implicit cast to base class

Question

Consider this piece of code:

struct Base
{
    int x;
};

struct Bar : Base
{
    int y;
};

struct Foo : Base
{
    int z;
};

Bar* bar = new Bar;
Foo* foo = new Foo;

Base* returnBase()
{
    Base* obj = !bar ? foo : bar;
    return obj;
}

int main() {
    returnBase();
    return 0;
}

This doesn't work under Clang or GCC, giving me :

error: conditional expression between distinct pointer types ‘Foo*’ and ‘Bar*’ lacks a cast Base* obj = !bar ? foo : bar;

Which means for it to compile I have to change the code to :

Base* obj = !bar ? static_cast<Base*>(foo) : bar;

Since an implicit cast to a Base* exists, what is preventing the compiler from doing so?

In other words, why does Base* obj = foo; work without a cast but using the ?: operator doesn't? Is it because it's not clear that I want to use the Base part?

Answer 1

Quoting from C++ standard draft N4296, Section 5.16 Conditional operator, Paragraph 6.3:

• One or both of the second and third operands have pointer type; pointer conversions (4.10) and qualification conversions (4.4) are performed to bring them to their composite pointer type (Clause 5). The result is of the composite pointer type.

Section 5 Expressions, Paragraph 13.8 and 13.9:

The composite pointer type of two operands p1 and p2 having types T1 and T2, respectively, where at least one is a pointer or pointer to member type or std::nullptr_t, is:

• if T1 and T2 are similar types (4.4), the cv-combined type of T1 and T2;
• otherwise, a program that necessitates the determination of a composite pointer type is ill-formed.

Note: I copied 5/13.8 here just to show you that it doesn't hit. What's actually in effect is 5/13.9, "the program is ill-formed".

And Section 4.10 Pointer conversions, Paragraph 3:

A prvalue of type “pointer to cv D”, where D is a class type, can be converted to a prvalue of type “pointer to cv B”, where B is a base class (Clause 10) of D. If B is an inaccessible (Clause 11) or ambiguous (10.2) base class of D, a program that necessitates this conversion is ill-formed. The result of the conversion is a pointer to the base class subobject of the derived class object. The null pointer value is converted to the null pointer value of the destination type.

So, it doesn't matter (at all) that both Foo and Bar are derived from one same base class. It only matters that a pointer to Foo and a pointer to Bar are not convertible to each other (no inheritance relationship).

Answer 2

Allowing a conversion to the base pointer type for the conditional operator sounds nice but would problematic in practice.

In your example

struct Base {};
struct Foo : Base {};
struct Bar : Base {};

It might seem like the obvious choice for the type of cond ? foo : bar to be Base*.

But that logic doesn't hold up for a general case

E.g.:

struct TheRealBase {};
struct Base : TheRealBase {};
struct Foo : Base {};
struct Bar : Base {};

Should cond ? foo : bar be of type Base* or of type TheRealBase*?

How about:

struct Base1 {};
struct Base2 {};
struct Foo : Base1, Base2 {};
struct Bar : Base1, Base2 {};

What type should cond ? foo : bar be now?

Or how about now:

struct Base {};

struct B1 : Base {};
struct B2 : Base {};

struct X {};

struct Foo : B1, X {};
struct Bar : B2, X {};


      Base
      /  \
     /    \   
    /      \
  B1        B2 
   |   X    |
   | /   \  |
   |/     \ |
  Foo      Bar

     
      

Ouch!! Good luck reasoning for a type of cond ? foo : bar. I know, ugly ugly, non-practical and being hunted worthy, but the standard would still have to have rules for this.

You get the point.

And also keep in mind that std::common_type is defined in terms of the conditional operator rules.

---

Hm... These are excellent examples of situations that couldn't work, because of ambiguity. But C++ has many conversion rules that do work as long as the conversion is unambiguous. Like in this question. No?

Allowing just the unambiguous case here would be extremely problematic. The simple act of adding a base class could make the program uncompilable:

Initial codebase:

struct Base {};
struct Foo : Base {};
struct Bar : Base {};

This would allow __ ? foo : bar; to be written. And now you can't modify the inheritance structure because almost any modification would break existing code that uses the ternary operator in a legitimate way:

struct FooBarCommon {};

struct Base {};
struct Foo : Base, FooBarCommon {};
struct Bar : Base, FooBarCommon {};
struct Baz : Base {};

This seems a reasonable modifications. As the rules are now you can do this as long as you don't modify the public API of your classes. This won't be true anymore the standard would allow the conversions to base class only in unambiguous cases.

Answer 3

In other words, why does Base* obj = foo; work without a cast but using the ?: operator doesn't?

The type of the conditional expression does not depend on the what it is assigned to. In your case, the compiler needs to be able to evaluate !bar ? foo : bar; regardless of what it is assigned to.

In your case, that is a problem since neither foo converted to type of bar nor bar can be converted to type of foo.

Is it because it's not clear that I want to use the Base part?

Precisely.

Answer 4

Since an implicit cast to a Base* exists, what is preventing the compiler from doing so?

According to [expr.cond]/7,

Lvalue-to-rvalue, array-to-pointer, and function-to-pointer standard conversions are performed on the second and third operands. After those conversions, one of the following shall hold:

• ...
• One or both of the second and third operands have pointer type; pointer conversions, function pointer conversions, and qualification conversions are performed to bring them to their composite pointer type. The result is of the composite pointer type.

where composite pointer type is defined in [expr.type]/4:

The composite pointer type of two operands p1 and p2 having types T1 and T2, respectively, where at least one is a pointer or pointer-to-member type or std?::?nullptr_­t, is:

• if both p1 and p2 are null pointer constants, std?::?nullptr_­t;

• if either p1 or p2 is a null pointer constant, T2 or T1, respectively;

• if T1 or T2 is “pointer to cv1 void” and the other type is “pointer to cv2 T”, where T is an object type or void, “pointer to cv12 void”, where cv12 is the union of cv1 and cv2;

• if T1 or T2 is “pointer to noexcept function” and the other type is “pointer to function”, where the function types are otherwise the same, “pointer to function”;

• if T1 is “pointer to cv1 C1” and T2 is “pointer to cv2 C2”, where C1 is reference-related to C2 or C2 is reference-related to C1, the cv-combined type of T1 and T2 or the cv-combined type of T2 and T1, respectively;

• if T1 is “pointer to member of C1 of type cv1 U1” and T2 is “pointer to member of C2 of type cv2 U2” where C1 is reference-related to C2 or C2 is reference-related to C1, the cv-combined type of T2 and T1 or the cv-combined type of T1 and T2, respectively;

• if T1 and T2 are similar types, the cv-combined type of T1 and T2;

• otherwise, a program that necessitates the determination of a composite pointer type is ill-formed.

Now you can see a pointer to "common base" is not the composite pointer type.

---

In other words, why does Base* obj = foo; work without a cast but using the ?: operator doesn't? Is it because it's not clear that I want to use the Base part?

The problem is that the rule should detect the type of the conditional expression independently, without observing the initialization.

To be specific, a rule should detect the conditional expressions in the following two statements to be the same type.

Base* obj = !bar ? foo : bar;
bar ? foo : bar;

Now, if you have no doubt that the conditional expression in the second statement is ill-formed¹, what's the reasoning to make it well-formed in the first statement?

---

_{¹ Of course one can make a rule to make such expression well-formed. For example, let composite pointer types include the pointer to an unambiguous base type. However, this is something beyond this question, and should be discussed by ISO C++ committee.}

Answer 5

exp1 ? exp2 : exp3

In the conditional operator, exp2 & exp3 must be of same type or alteast it should have type conversion function which converts one type to another. If not, then it is ill-formed.

    int i = 1;
    long j = 2;
    true  ? i : j; // OK
    false ? i : j; // OK


    string str1 = "hello";
    const char* str2 = "world";
    true  ? str1 : str2; // OK
    false ? str1 : str2; // OK

    int i = 1;
    string str1 = "hello";
    true  ? i : str1; // Error: No conversion from 'std::string' to 'int'
    false ? i : str1; // Error: No conversion from 'std::string' to 'int'