Validating and comparing req.body values to founduser values

Question

I have an api for reseting password. This api checks if there is a user with the entered phone number and if there is any it checks whether the inputs like dob, nationality and idnumber are also correct then if they are it then generates a new password for the user. However am using many if statements . So my question is whether this is practical or i should change my syntax for performance sake of the app and general good practices for writing standard code.

I have attached my code below with bunch of if statements lol

const asyncHandler = require("express-async-handler");
const User = require("../../models/user")
const bcrypt = require("bcrypt");
const jwt = require("jsonwebtoken");

const generateStrongPassword = require('../../utils/generateStrongPassword');


const resetPassword = asyncHandler(async (req, res) => {
    const { phonenumber, fullname, nationality, nationalidnumber, dateofbirth } = req.body;
    const user = await User.findOne({ phonenumber: phonenumber });

    if (user) {
        if (fullname != user.fullname) {
            throw new Error('incorrect fullname');
        }

        if (nationality != user.nationality) {
            throw new Error('incorrect nationality');
        }

        if (nationalidnumber != user.nationalidnumber) {
            throw new Error('incorrect national id number ');
        }

        if (dateofbirth != user.dateofbirth) {
            throw new Error('incorrect date of birth');
        }

        // if all validations are passed then
        // generate new password
        const newrawpassword = await generateStrongPassword();
        console.log(newrawpassword);
        
        // harsh the password
        const salt = await bcrypt.genSalt(10);
        const newHashedPassword = await bcrypt.hash(newrawpassword, salt);

        const resetPassword = await User.updateOne({ $set: { password: newHashedPassword } })

        res.json('password successfully reseted')

    } else {
        throw new Error('No account has that phone number');
    }
});

module.exports = resetPassword;

Answer 1

My first question is: Why not do this in BigQuery? I'm no BQ expert but I think window functions or the LAG function would allow you to say: "For each result, give me the previous N results".

Beam does not have any concept of "previous N records" out of the box. By design, PCollection elements have no context of any adjacent records. You can probably use a GroupByKey function for this however.

1. Duplicate each row into key/value pairs for ALL elements to which this might possible pertain
2. Use GroupByKey to group

For example, if your table looks like this:

my_key | my_value
1      | "Goodbye Earl"
2      | "Cowboy Take Me Away"
3      | "Sin Wagon"
4      | "Traveling Soldier"

Assume each row requires the previous 2. In this case, row 1 will eventually be needed by row 2 and row 3. Row 2 by row 3 and row 4; etc. Create a DoFn class which outputs all of these elements for each element.

[
    (1, "Goodbye Earl"),
    (2, "Goodbye Earl"),
    (3, "Goodbye Earl")
]

[
    (2, "Cowboy Take Me Away"),
    (3, "Cowboy Take Me Away"),
    (4, "Cowboy Take Me Away")
]

For row 2, GroupByKey would give you a list of elements which you can aggregate on.

["Goodbye Earl", "Cowboy Take Me Away"]

Most likely you would want to parse the BigQuery rows into a data class. That way you can identify which ones are original and which ones are copies.