'Does i = x[i]++; lead to undefined behavior?
Can someone please explain whether i = x[i]++;
lead to undefined behavior?
Note: x[i]
and i
are not both volatile and x[i]
does not overlap i
.
There is C11, 6.5 Expressions, 2 (emphasis added):
If a side effect on a scalar object is unsequenced relative to either a different side effect on the same scalar object or a value computation using the value of the same scalar object, the behavior is undefined. If there are multiple allowable orderings of the subexpressions of an expression, the behavior is undefined if such an unsequenced side effect occurs in any of the orderings. 84)
As I understand:
- there is no "different side effect on the same scalar object"
- there is no "value computation using the value of the same scalar object"
Are there "multiple allowable orderings"?
Overall: how can the i = x[i]++;
be interpreted w.r.t. sequence points, side effects, and undefined behavior (if any)?
UPD. Conclusion: the i = x[i]++;
leads to 2 side effects:
- "the value of the operand object is incremented" (Postfix increment)
- "updating the stored value of the left operand" (Assignment operators)
The Standard does not define the order in which the side effects take place.
Hence, per C11, 4. Conformance, 2:
Undefined behavior is otherwise indicated in this International Standard by the words ‘‘undefined behavior’’ or by the omission of any explicit definition of behavior.
Experiments show that GCC/LLVM/ICC have order 1-2
, while MSVC (and some others) have order 2-1
.
Extra (speculating): why not making it unspecified behavior? Example: "an example of unspecified behavior is the order in which the side effects take place"?
Solution 1:[1]
Imagine:
i = 3;
x[] = {1, 1, 1, 1, 1};
So, x[i]
equals 1, x[i]++
equals 2 and x
becomes {1, 1, 2, 1, 1}
, and i
becomes 1.
Why would there be any undefined behaviour?
Solution 2:[2]
If it were true that
- there is no "different side effect on the same scalar object"
- there is no "value computation using the value of the same scalar object"
(in every allowed ordering of the subexpressions), then the provision you cite would present no particular issue. That is, the antecedent of its "if" would not hold, so the consequence of that "if" (undefined behavior) would not be asserted.
However, there is both a side effect on i
and a value computation using the value of i
. The former is the side effect of the assignment, and the latter is the value computation of x[i]++
. This is not a problem, however, because, for all forms of assignment,
The side effect of updating the stored value of the left operand is sequenced after the value computations of the left and right operands.
(C17 6.5.16/3)
Also, for completeness,
The value computations of the operands of an operator are sequenced before the value computation of the result of the operator.
(C17 6.5/1)
Thus, the assignment's side effect on i
is sequenced after the value computation of x[i]++
, which is sequenced after the evaluation of i
.
Solution 3:[3]
There is a value computation using the value of the same scalar object. x[i]
uses the value of i
.
Since C11, there is a sequence relation in assignment.
The side effect of updating the stored value of the left operand is sequenced after the value computations of the left and right operands.
(C11 6.5.16/3)
Prior to then the way the standard discussed expressions was looser. It did not describe a sequenced before relation. Instead we have:
Between the previous and next sequence point an object shall have its stored value modified at most once by the evaluation of an expression. Furthermore, the prior value shall be read only to determine the value to be stored.
You aren't reading the value "other than to determine the value to be stored", so the behaviour is defined.
(C99 6.5/2)
Sources
This article follows the attribution requirements of Stack Overflow and is licensed under CC BY-SA 3.0.
Source: Stack Overflow
Solution | Source |
---|---|
Solution 1 | |
Solution 2 | John Bollinger |
Solution 3 |